Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(package): missing assemble runtime dependency #167

Closed
wants to merge 1 commit into from

Conversation

zeropaper
Copy link

I had a missing dependency error at runtime.

I had a missing dependency error at runtime.
@doowb
Copy link
Member

doowb commented Nov 21, 2014

assemble shouldn't be a dependency in this repository.

@doowb doowb closed this Nov 21, 2014
@zeropaper
Copy link
Author

OK.. make sense.
Still it looks like there's a missing assemble runtime dependency issue to solve.

@doowb
Copy link
Member

doowb commented Nov 21, 2014

Are you using grunt or gulp or something else with this library?

@zeropaper
Copy link
Author

actually, grunt to "assemble"...

On Fri, Nov 21, 2014 at 7:27 PM, Brian Woodward notifications@github.com
wrote:

Are you using grunt or gulp or something else with this library?


Reply to this email directly or view it on GitHub
#167 (comment)
.

¦ Valentin Vago
¦ valentin.vago@gmail.com
¦ http://irata.graphics

@doowb
Copy link
Member

doowb commented Nov 21, 2014

Can I see your gruntfile.js and package.json? There might be something missing.

@zeropaper
Copy link
Author

Sure, it's here: https://github.com/zeropaper/DATA/tree/site

I will dig a bit as well.

On Fri, Nov 21, 2014 at 8:17 PM, Brian Woodward notifications@github.com
wrote:

Can I see your gruntfile.js and package.json? There might be something
missing.


Reply to this email directly or view it on GitHub
#167 (comment)
.

¦ Valentin Vago
¦ valentin.vago@gmail.com
¦ http://irata.graphics

@akileez
Copy link

akileez commented Nov 22, 2014

you are using load-grunt-tasks. you must assign assemble as one of the patterns to load explicitly as this task will only load grunt-tasks by default.

require('load-grunt-tasks')(grunt);

should be something like:

require('load-grunt-tasks')(grunt, {pattern: 'grunt-*', assemble});

@zeropaper
Copy link
Author

Thanks a lot!

I managed to fix my issue by removing the handlebars-helpers and handlebars-helper-md from my assemble configuration.

But your hint about load-grunt-tasks is really interesting. Will keep in mind.

@ain
Copy link

ain commented Nov 22, 2014

I'd actually suggest converting to JIT Grunt. If you're using livereload for instance, you'll get your speed up considerably. The more tasks, the slower load-grunt-tasks will make it as you're loading tasks that you are not really using during the development.

@jonschlinkert
Copy link
Member

I'd actually suggest converting to JIT Grunt. If you're using livereload for instance, you'll get your speed up considerably.

Only if you're using an old Assemble version. WIth Assemble v0.6.0, there is no need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants